[VC-48429] Helm chart updates for encrypted secrets#783
Merged
SgtCoDFish merged 4 commits intomasterfrom Mar 5, 2026
Merged
Conversation
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
force-pushed
the
chart-update
branch
3 times, most recently
from
f4d0c2e to
2ed683a
Compare
SgtCoDFish
commented
Mar 4, 2026
Comment on lines
+56
to
+57
| // TODO: When standardised, consider using secret.Do to wrap this call, since it will generate an AES key | ||
| // (see https://pkg.go.dev/runtime/secret) |
Contributor
Author
There was a problem hiding this comment.
self-review: this comment update is unrelated but I wanted to clarify it. secret.Do is behind GOEXPERIMENT in 1.26 and I didn't want to open that can of worms.
FelixPhipps
approved these changes
Mar 4, 2026
Contributor
FelixPhipps
left a comment
FelixPhipps
left a comment
There was a problem hiding this comment.
Mostly comments and small changes, can't find any fault or cause for concern here 👍
SgtCoDFish
force-pushed
the
chart-update
branch
2 times, most recently
from
d3028d2 to
e0361aa
Compare
This adds a new environment variable to skip running live tests unless explicitly opted in Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
We're seeing flakes and bugs in the version detection logic in the backend, which has caused our tests to break a few times. Instead, let's send an explicit request for sigv4 to avoid the version logic Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Enables secret sending by default when ToS is accepted.
Also adds acceptTerms validation, which causes the chart to error out if
the value is not set.
The error looks like this:
```console
$ helm template foo ./deploy/charts/disco-agent
Error: execution error at (disco-agent/templates/deployment.yaml:2:6):
=================================================================
Terms & Conditions Notice
=================================================================
Before installing this application, you must review and accept
the terms and conditions available at:
https://www.cyberark.com/contract-terms/
To proceed with installation, you must indicate acceptance by
setting:
- In your values file: acceptTerms: true
or
- Via the Helm flag: --set acceptTerms=true
By continuing with the next command, you confirm that you have
reviewed and accepted these terms and conditions.
=================================================================
```
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a terms and conditions notice from @achuchev